$(document).pjax:complete - Code Metrics - Inspection of "flashes fix" - Strontium-90/StrontiumPjaxBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d31101...5680bf )

by Aleksey

created 2016-07-28 11:14 UTC

$(document).pjax:complete A

↳ Parent: Resources/public/js/flash.js

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
c	1
b	0
f	0
nc	1
nop	1
dl	0
loc	3
rs	10

(function ($, app) {
    'use strict';

    $.extend(app, {
        PJAX_FLASH_CONTAINER: '.notification-container',
        PJAX_FLASH: 'pjax-flashes',
        PJAX_FLASH_SELECTOR: '[data-pjax-flashes]',

        MESSAGE_SUCCESS: 0,
        MESSAGE_ERROR: 1,
        MESSAGE_WARNING: 2,
        MESSAGE_NOTICE: 3,

        message: function (text, status) {
            this.clearMessage();
            if (!status) {
                status = this.MESSAGE_SUCCESS;
            }

            var msgbox = $('<div></div>').appendTo(app.PJAX_FLASH_CONTAINER);
            msgbox.addClass('alert');
            msgbox.hide();
            msgbox.text(text);
            switch (status) {

                case this.MESSAGE_SUCCESS :
                case 'success' :
                    msgbox.addClass('alert-success');
                    break;
                case this.MESSAGE_NOTICE :
                case 'notice' :
                    msgbox.addClass('alert-info');
                    break;
                case this.MESSAGE_WARNING :
                    msgbox.addClass('alert-warning');
                    msgbox.html('<i class="icon-warning-sign"></i> ' + msgbox.text());
                    break;
                case this.MESSAGE_ERROR :
                case 'error' :
                    msgbox.addClass('alert-danger');
                    msgbox.html('<i class="icon-erroralt"></i> ' + msgbox.text());
                    break;
            }

            msgbox.data("time", new Date());
            msgbox.fadeIn(500);

        },

        clearMessage: function () {
            $(app.PJAX_FLASH_CONTAINER + ' > div').each(function () {
                var time = $(this).data("time");
                if (!time || (new Date() - time >= 5 * 1000)) {
                    $(this).fadeOut(1000, function () {
                        $(this).html("");
                    });
                }
            });
        }
    });

    $(document)
        .on('pjax:send', app.clearMessage)
        .on('pjax:error', function (event, xhr, textStatus, error, options) {

            if ('abort' !== textStatus) {
                app.message('Error', app.MESSAGE_ERROR);
            }
        })
        .on('pjax:beforeReplace', function (event, contents, options) {

            var tmp = $('<div></div>');
            tmp.html(contents);
            var flashes = $(app.PJAX_FLASH_SELECTOR, tmp);
            if (flashes) {
                var flashData = flashes.data(app.PJAX_FLASH);
                if (flashData) {
                    $(app.PJAX_FLASH_CONTAINER).html(flashData);
                }
                flashes.removeData(app.PJAX_FLASH);
                flashes.removeAttr('data-' + app.PJAX_FLASH);
            }
        });

})(jQuery, application);



1			(function ($, app) {
2			'use strict';
3
4			$.extend(app, {
5			PJAX_FLASH_CONTAINER: '.notification-container',
6			PJAX_FLASH: 'pjax-flashes',
7			PJAX_FLASH_SELECTOR: '[data-pjax-flashes]',
8
9			MESSAGE_SUCCESS: 0,
10			MESSAGE_ERROR: 1,
11			MESSAGE_WARNING: 2,
12			MESSAGE_NOTICE: 3,
13
14			message: function (text, status) {
15			this.clearMessage();
16			if (!status) {
17			status = this.MESSAGE_SUCCESS;
18			}
19
20			var msgbox = $('<div></div>').appendTo(app.PJAX_FLASH_CONTAINER);
21			msgbox.addClass('alert');
22			msgbox.hide();
23			msgbox.text(text);
24			switch (status) {
			0 ignored issues – show Coding Style introduced 2016-07-08 10:43 UTC by Report Bug Copy Issue Report As per coding-style, `switch` statements should have a `default` case. Loading history...
25			case this.MESSAGE_SUCCESS :
26			case 'success' :
27			msgbox.addClass('alert-success');
28			break;
29			case this.MESSAGE_NOTICE :
30			case 'notice' :
31			msgbox.addClass('alert-info');
32			break;
33			case this.MESSAGE_WARNING :
34			msgbox.addClass('alert-warning');
35			msgbox.html('<i class="icon-warning-sign"></i> ' + msgbox.text());
36			break;
37			case this.MESSAGE_ERROR :
38			case 'error' :
39			msgbox.addClass('alert-danger');
40			msgbox.html('<i class="icon-erroralt"></i> ' + msgbox.text());
41			break;
42			}
43
44			msgbox.data("time", new Date());
45			msgbox.fadeIn(500);
46
47			},
48
49			clearMessage: function () {
50			$(app.PJAX_FLASH_CONTAINER + ' > div').each(function () {
51			var time = $(this).data("time");
52			if (!time \|\| (new Date() - time >= 5 * 1000)) {
53			$(this).fadeOut(1000, function () {
54			$(this).html("");
55			});
56			}
57			});
58			}
59			});
60
61			$(document)
62			.on('pjax:send', app.clearMessage)
63			.on('pjax:error', function (event, xhr, textStatus, error, options) {
			0 ignored issues – show Unused Code introduced 2016-07-08 10:43 UTC by Report Bug Copy Issue Report The parameter `options` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history... Unused Code introduced 2016-07-08 10:43 UTC by Report Bug Copy Issue Report The parameter `error` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
64			if ('abort' !== textStatus) {
65			app.message('Error', app.MESSAGE_ERROR);
66			}
67			})
68			.on('pjax:beforeReplace', function (event, contents, options) {
			0 ignored issues – show Unused Code introduced 2016-07-08 10:43 UTC by Report Bug Copy Issue Report The parameter `options` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
69			var tmp = $('<div></div>');
70			tmp.html(contents);
71			var flashes = $(app.PJAX_FLASH_SELECTOR, tmp);
72			if (flashes) {
73			var flashData = flashes.data(app.PJAX_FLASH);
74			if (flashData) {
75			$(app.PJAX_FLASH_CONTAINER).html(flashData);
76			}
77			flashes.removeData(app.PJAX_FLASH);
78			flashes.removeAttr('data-' + app.PJAX_FLASH);
79			}
80			});
81
82			})(jQuery, application);
			0 ignored issues – show Bug introduced 2016-07-08 10:43 UTC by Report Bug Copy Issue Report The variable `application` seems to be never declared. If this is a global, consider adding a `/** global: application */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
83

Strontium-90 / StrontiumPjaxBundle

GitHub Access Token became invalid

Push — master ( d31101...5680bf )

$(document).pjax:complete A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like